Discussion:
[erlang-patches] Fix DTrace/SystemTap-related formatting
unknown
2014-03-25 09:58:18 UTC
Permalink
Thanks to Michal Ptaszek for bringing this embarrassing formatting
error to my attention. Many DTrace/SystemTap trace strings are
incorrectly truncated at 4/8 bytes, depending on the CPU word size.
This patch expands the work from commit d032e09 by zheng siyao.

Michal's report to the erlang-bugs list can be found at:
http://erlang.org/pipermail/erlang-bugs/2014-March/004250.html

git fetch git://github.com/slfritchie/otp.git dtrace-formatting-refix

https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix
https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix.patch

It'd be really nice if this could squeak in before the 17 release
is frozen. Many apologies if I've missed the deadline.

-Scott
unknown
2014-03-25 11:07:10 UTC
Permalink
Replying here as well for the record.

A patch[1] has already been made by Michal Ptaszek. I've appended the
non-overlapping parts of this patch to Michal's patch and merged to
master for release in 17.0.

Lukas

[1]: https://github.com/erlang/otp/pull/292

On 25/03/14 10:58, Scott Lystig Fritchie wrote:
> Thanks to Michal Ptaszek for bringing this embarrassing formatting
> error to my attention. Many DTrace/SystemTap trace strings are
> incorrectly truncated at 4/8 bytes, depending on the CPU word size.
> This patch expands the work from commit d032e09 by zheng siyao.
>
> Michal's report to the erlang-bugs list can be found at:
> http://erlang.org/pipermail/erlang-bugs/2014-March/004250.html
>
> git fetch git://github.com/slfritchie/otp.git dtrace-formatting-refix
>
> https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix
> https://github.com/slfritchie/otp/compare/erlang:master...dtrace-formatting-refix.patch
>
> It'd be really nice if this could squeak in before the 17 release
> is frozen. Many apologies if I've missed the deadline.
>
> -Scott
> _______________________________________________
> erlang-patches mailing list
> erlang-patches
> http://erlang.org/mailman/listinfo/erlang-patches
>
Loading...