Discussion:
[erlang-patches] Use isfinite() instead of finite() when available
unknown
2013-11-15 01:53:13 UTC
Permalink
Hello,

This fixes the following warning on Mac OS X 10.9 Mavericks:

hipe/hipe_bif0.c:1025:10: warning: 'finite' is deprecated: first deprecated in OS X 10.9 [-Wdeprecated-declarations]
if (!finite(p->hipe.float_result)) {
^
/usr/include/math.h:718:12: note: 'finite' declared here
extern int finite(double) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_9, __IPHONE_NA, __IPHONE_NA);
^

git fetch https://github.com/nox/otp isfinite

https://github.com/nox/otp/compare/isfinite
https://github.com/nox/otp/compare/isfinite.patch

Regards,
--
Anthony Ramine
unknown
2013-11-15 08:01:49 UTC
Permalink
Post by unknown
Hello,
hipe/hipe_bif0.c:1025:10: warning: 'finite' is deprecated: first deprecated in OS X 10.9 [-Wdeprecated-declarations]
if (!finite(p->hipe.float_result)) {
^
/usr/include/math.h:718:12: note: 'finite' declared here
extern int finite(double) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_9, __IPHONE_NA, __IPHONE_NA);
^
git fetch https://github.com/nox/otp isfinite
https://github.com/nox/otp/compare/isfinite
https://github.com/nox/otp/compare/isfinite.patch
Regards,
Hello Anthony,
Fetched your patch and assigned it to be reviewed by responsible developers.
Thanks!
--
BR Fredrik Gustafsson
Erlang OTP Team
unknown
2014-01-13 11:17:25 UTC
Permalink
Hi

This fails on ~20 platforms.
Linux x86 and linux powerpc

*** CT Error Notification 2014-01-11 22:50:02.984 ***
float_SUITE:fp_drv_test failed on line 130
Reason: load_error

Full error description and stacktrace




=== Ended at 2014-01-11 22:50:02
=== location [{float_SUITE,fp_drv_test,130},
{test_server,ts_tc,1360},
{test_server,run_test_case_eval1,977},
{test_server,run_test_case_eval,925}]
=== reason = {load_error,"wrong ELF class: ELFCLASS32"}

------------------------------------------------------------------------------------------------

*** CT Error Notification 2014-01-11 22:36:13.287 ***
float_SUITE:fp_drv_test failed on line 130
Reason: load_error

Full error description and stacktrace




=== Ended at 2014-01-11 22:36:13
=== location [{float_SUITE,fp_drv_test,130},
{test_server,ts_tc,1360},
{test_server,run_test_case_eval1,977},
{test_server,run_test_case_eval,925}]
=== reason = {load_error,"undefined symbol: isfinite"}
Post by unknown
Hello,
hipe/hipe_bif0.c:1025:10: warning: 'finite' is deprecated: first deprecated in OS X 10.9 [-Wdeprecated-declarations]
if (!finite(p->hipe.float_result)) {
^
/usr/include/math.h:718:12: note: 'finite' declared here
extern int finite(double) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_9, __IPHONE_NA, __IPHONE_NA);
^
git fetch https://github.com/nox/otp isfinite
https://github.com/nox/otp/compare/isfinite
https://github.com/nox/otp/compare/isfinite.patch
Regards,
--
/Henrik Nord Erlang/OTP
Loading...