[erlang-patches] Fix DTrace build on Illumos

[unknown]

https://github.com/erlang/otp/pull/156

This patch fixes the configure and Makefile scripts to work with newer
DTrace. This applies to all Illumos derivatives including OpenIndiana,
SmartOS and OmnioOS. I've copied the commit message here verbatim.

--- SNIP ---

Fix DTrace build on Illumos

DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.

* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59

This patch fixes two issues:

* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.

* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.

[1]:
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99

--- END SNIP ---

-Z
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20131207/79b18e01/attachment.html>

[unknown]

Thank you for your contribution !

patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with newer
DTrace. This applies to all Illumos derivatives including OpenIndiana,
SmartOS and OmnioOS. I've copied the commit message here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

[unknown]

Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.

Post by unknown
Thank you for your contribution !
patch has been assigned to be reviewed
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with newer
DTrace. This applies to all Illumos derivatives including OpenIndiana,
SmartOS and OmnioOS. I've copied the commit message here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing listerlang-patches://erlang.org/mailman/listinfo/erlang-patches
--
/Henrik Nord Erlang/OTP

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140115/5f0fb489/attachment.html>

[unknown]

Hello,

We are working on a way to verify this on our test machines. We intend
to have this fix merged before the upcoming release.

Lukas

Post by unknown
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.
On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <henrik
Thank you for your contribution !
patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with
newer DTrace. This applies to all Illumos derivatives including
OpenIndiana, SmartOS and OmnioOS. I've copied the commit message
here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140116/e8ebe43c/attachment-0001.html>

[unknown]

patch has been merged to master.

Thank you for your contribution.

Lukas

Post by unknown
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.
On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <henrik
Thank you for your contribution !
patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with
newer DTrace. This applies to all Illumos derivatives including
OpenIndiana, SmartOS and OmnioOS. I've copied the commit message
here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140128/2655926a/attachment.html>

[unknown]

Hello Ryan,

I just noticed that you removed the "2> /dev/null" for the 2STEP_TEST in
erts/configure.in. Was there a reason for doing that? As it is now when
the test fails on osx in prints the output of the dtrace command to the
shell which is not really what you want.

Lukas

Post by unknown
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.
On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <henrik
Thank you for your contribution !
patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with
newer DTrace. This applies to all Illumos derivatives including
OpenIndiana, SmartOS and OmnioOS. I've copied the commit message
here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140204/f3ba4c4f/attachment.html>

[unknown]

Hi Lukas,

If I recall correctly, I did that so that the exact failure reason would be
more obvious when dtrace fails build. When I first ran into this problem
months ago it was hard for me to determine what the issue was and my
thinking is that this output would help. Perhaps it is not useful? I will
not object if you feel this particular change needs to be reverted but I
also didn't make the change by accident.

-Z

Post by unknown
Hello Ryan,
I just noticed that you removed the "2> /dev/null" for the 2STEP_TEST in
erts/configure.in. Was there a reason for doing that? As it is now when
the test fails on osx in prints the output of the dtrace command to the
shell which is not really what you want.
Lukas
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.

Post by unknown
Thank you for your contribution !
patch has been assigned to be reviewed
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work with newer
DTrace. This applies to all Illumos derivatives including OpenIndiana,
SmartOS and OmnioOS. I've copied the commit message here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing listerlang-patches://erlang.org/mailman/listinfo/erlang-patches
--
/Henrik Nord Erlang/OTP

_______________________________________________
erlang-patches mailing listerlang-patches://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140204/4ca08327/attachment.html>

[unknown]

Ok, thanks, good to know. I'll rewrite it so that the error message gets
put in the config.log instead of being printed to stdout.

Lukas

Post by unknown
Hi Lukas,
If I recall correctly, I did that so that the exact failure reason
would be more obvious when dtrace fails build. When I first ran into
this problem months ago it was hard for me to determine what the issue
was and my thinking is that this output would help. Perhaps it is not
useful? I will not object if you feel this particular change needs to
be reverted but I also didn't make the change by accident.
-Z
On Tue, Feb 4, 2014 at 12:24 PM, Lukas Larsson <lukas
Hello Ryan,
I just noticed that you removed the "2> /dev/null" for the
2STEP_TEST in erts/configure.in <http://configure.in>. Was there a
reason for doing that? As it is now when the test fails on osx in
prints the output of the dtrace command to the shell which is not
really what you want.
Lukas

Post by unknown
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.
On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <henrik
Thank you for your contribution !
patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work
with newer DTrace. This applies to all Illumos derivatives
including OpenIndiana, SmartOS and OmnioOS. I've copied the
commit message here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace
Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace
probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in
the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140205/57550cc6/attachment-0001.html>

[unknown]

Hello,

Would you mind testing my modifications on Illumos? You can get them
here[1], I've tested on os x and freebsd.

Lukas

[1]:
https://github.com/garazdawi/otp/tree/lukas/erts/dtrace-config-logging

Post by unknown
Hi Lukas,
If I recall correctly, I did that so that the exact failure reason
would be more obvious when dtrace fails build. When I first ran into
this problem months ago it was hard for me to determine what the issue
was and my thinking is that this output would help. Perhaps it is not
useful? I will not object if you feel this particular change needs to
be reverted but I also didn't make the change by accident.
-Z
On Tue, Feb 4, 2014 at 12:24 PM, Lukas Larsson <lukas
Hello Ryan,
I just noticed that you removed the "2> /dev/null" for the
2STEP_TEST in erts/configure.in <http://configure.in>. Was there a
reason for doing that? As it is now when the test fails on osx in
prints the output of the dtrace command to the shell which is not
really what you want.
Lukas

Post by unknown
Any news? Would be nice if R17 worked with DTrace on latest Illumos kernel.
On Tue, Dec 10, 2013 at 8:26 AM, Henrik Nord <henrik
Thank you for your contribution !
patch has been assigned to be reviewed

Post by unknown
https://github.com/erlang/otp/pull/156
This patch fixes the configure and Makefile scripts to work
with newer DTrace. This applies to all Illumos derivatives
including OpenIndiana, SmartOS and OmnioOS. I've copied the
commit message here verbatim.
--- SNIP ---
Fix DTrace build on Illumos
DTrace was recently patched in Illumos to fail to create an object
file if no probes are found.
* https://www.illumos.org/issues/4248
*
https://github.com/illumos/illumos-gate/commit/54a20ab41aadcb81c53e72fc65886e964e9add59
* Modify the configure script to pass an object file to `dtrace -G`
that actually invokes a probe.
* Remove creation of `dtrace_user.o` from the dyntrace
Makefile. In a
previous commit [1] Scott Fritchie relocated all the user probes
into the VM proper due to difficulties with DTrace
probes in shared
libraries. The `dtrace_user.d` file is now empty and generates a
header file with nothing in it. There is no longer any reason to
generate `dtrace_user.o` because all the probes are in
the VM. Thus
all the steps for building `dtrace_user.o` have been removed.
https://github.com/erlang/otp/commit/75552bd3bb4e7f3cf4dab81a5c81cf73b1d3fb99
--- END SNIP ---
-Z
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches <mailto:erlang-patches>
http://erlang.org/mailman/listinfo/erlang-patches

_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140205/c2d074e0/attachment.html>

[unknown]

Hi Lukas,

Post by unknown
Would you mind testing my modifications on Illumos? You can get them
here[1], I've tested on os x and freebsd.

Sorry for the delay. I tested on SmartOS and everything worked (I made sure
the probes showed up).

-Z
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140218/2bd767df/attachment.html>

[unknown]

Post by unknown
Hi Lukas,
On Wed, Feb 5, 2014 at 10:29 AM, Lukas Larsson <lukas
Would you mind testing my modifications on Illumos? You can get
them here[1], I've tested on os x and freebsd.
Sorry for the delay. I tested on SmartOS and everything worked (I made
sure the probes showed up).

Great! thanks!

Lukas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140219/d38a605b/attachment.html>