[erlang-patches] sasl: Fix function_clause in systools_make:format_error/1

[unknown]

Hi!

Here's a small patch which fixes a 'function_clause' error when running
systools:make_script/2 and there are duplicate modules.

git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error

https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch

Thank you!
--
Jean-S?bastien P?dron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140319/d73ca42b/attachment.bin>

[unknown]

Thanks!

We will take a look at it.
I also created a pullrequest from your link down below.

Post by unknown
Hi!
Here's a small patch which fixes a 'function_clause' error when running
systools:make_script/2 and there are duplicate modules.
git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch
Thank you!
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

[unknown]

The fix is good and will be included in OTP 17.0. It would be really good
if you could add a test case for it also, so it does not happen again.

Thanks!
/siri

Post by unknown
Thanks!
We will take a look at it.
I also created a pullrequest from your link down below.
Hi!
Here's a small patch which fixes a 'function_clause' error when running
systools:make_script/2 and there are duplicate modules.
git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error <http://github.com/dumbbell/otp.gitfunction_clause-in-systools_make-format_error>
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_errorhttps://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch
Thank you!
_______________________________________________
erlang-patches mailing listerlang-patches://erlang.org/mailman/listinfo/erlang-patches
--
/Henrik Nord Erlang/OTP
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140320/499813a7/attachment.html>

[unknown]

It would be really good if you could add a test case for it also, so
it does not happen again.

I pushed a second commit to the same branch to add a test case.

Here's the branch information again, just in case:

git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error

https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch

Thank you!
--
Jean-S?bastien P?dron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140324/56c236a2/attachment.bin>

[unknown]

Hi
As I mentioned in the previous email, I created a pull request from your
branch.
Now that you are adding to it, It would be nice if you could create your
own PR from your branch so that you can keep that up to date.

Also, keep in mind the guidelines for writing good commit messages.
https://github.com/erlang/otp/wiki/Writing-good-commit-messages


Thank you for your contributions!

Post by unknown

It would be really good if you could add a test case for it also, so
it does not happen again.

I pushed a second commit to the same branch to add a test case.
git fetch git://github.com/dumbbell/otp.git
function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error
https://github.com/dumbbell/otp/compare/erlang:maint...function_clause-in-systools_make-format_error.patch
Thank you!
_______________________________________________
erlang-patches mailing list
erlang-patches
http://erlang.org/mailman/listinfo/erlang-patches

[unknown]

Post by unknown
Now that you are adding to it, It would be nice if you could create your
own PR from your branch so that you can keep that up to date.

Hi!

That's what I tried before replying but GitHub reuses the current pull
request.

I'm not used to work with pull requests. What would you suggest? Do you
want me to amend the commits (maybe squash them into one) and improve
the commit message at the same time?
--
Jean-S?bastien P?dron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140324/cb448633/attachment.bin>

[unknown]

It's ok to use the current pull request. And yes, please squash the commits
into one and fix the commit message (please read this page again, it's just
been updated:
https://github.com/erlang/otp/wiki/Writing-good-commit-messages)

Thanks
/siri


2014-03-24 16:14 GMT+01:00 Jean-S?bastien P?dron <

Post by unknown

Post by unknown
Now that you are adding to it, It would be nice if you could create your
own PR from your branch so that you can keep that up to date.

Hi!
That's what I tried before replying but GitHub reuses the current pull
request.
I'm not used to work with pull requests. What would you suggest? Do you
want me to amend the commits (maybe squash them into one) and improve
the commit message at the same time?
--
Jean-S?bastien P?dron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140324/3da42920/attachment.html>

[unknown]

Post by unknown
It's ok to use the current pull request. And yes, please squash the
commits into one and fix the commit message (please read this page
again, it's just been
updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages)

Ok, commits squashed and message changed.

The new commit message guidelines are clearer, thanks.
--
Jean-S?bastien P?dron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140324/12ef27c4/attachment.bin>

[unknown]

Great, thanks! /siri


2014-03-24 17:57 GMT+01:00 Jean-S?bastien P?dron <

Post by unknown

Post by unknown
It's ok to use the current pull request. And yes, please squash the
commits into one and fix the commit message (please read this page
again, it's just been
updated: https://github.com/erlang/otp/wiki/Writing-good-commit-messages

)
Ok, commits squashed and message changed.
The new commit message guidelines are clearer, thanks.
--
Jean-S?bastien P?dron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140325/c9086143/attachment.html>

[unknown]

This patch has been graduated! Thanks for your contribution!
/siri

Post by unknown
Great, thanks! /siri
2014-03-24 17:57 GMT+01:00 Jean-S?bastien P?dron <

Post by unknown

Post by unknown
It's ok to use the current pull request. And yes, please squash the
commits into one and fix the commit message (please read this page
again, it's just been

https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
Ok, commits squashed and message changed.
The new commit message guidelines are clearer, thanks.
--
Jean-S?bastien P?dron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20140328/7513fe1a/attachment.html>